fix(client): run set to AllB returns B

fossapps · Jul 11, 2020 · c645432 · c645432
1 parent 217f55b
commit c645432
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/Sdk.Test/FeatureClientTest.cs b/Sdk.Test/FeatureClientTest.cs
@@ -36,6 +36,15 @@ public void Setup()
                     FeatureToken = GetUuid(),
                     RunId = GetUuid(),
                     RunToken = GetUuid()
+                },
+                new RunningFeature
+                {
+                    Allocation = 50,
+                    FeatureId = "APP-3",
+                    FeatureToken = GetUuid(),
+                    RunId = GetUuid(),
+                    RunStatus = "AllB",
+                    RunToken = GetUuid()
                 }
             };
             var mockWorker = new Mock<IFeatureWorker>();
@@ -101,5 +110,22 @@ public void TestFeatureWithAllocationHasLowAllocationBias()
             Assert.LessOrEqual(biasPerc, 0.5);
             Assert.LessOrEqual(biasWithZPerc, 0.5);
         }
+
+        [Test]
+        public void TestFeatureWithAllBAlwaysReturnsB()
+        {
+            var dictionary = new Dictionary<char, int> {['A'] = 0, ['B'] = 0, ['X'] = 0, ['Z'] = 0};
+            var client = new FeatureClient(_featureWorker, _userDataRepo);
+            for (var i = 0; i < 1000000; i++)
+            {
+                var variant = client.GetVariant("APP-3");
+                dictionary[variant] = dictionary[variant] + 1;
+            }
+
+            Assert.AreEqual(0, dictionary['X']);
+            Assert.AreEqual(0, dictionary['Z']);
+            Assert.AreEqual(0, dictionary['A']);
+            Assert.AreEqual(1000000, dictionary['B']);
+        }
     }
 }
diff --git a/Sdk/FeatureContainer.cs b/Sdk/FeatureContainer.cs
@@ -90,6 +90,11 @@ public char GetVariant(string featId)
                 return 'X';
             }
 
+            if (feature.RunStatus == "AllB")
+            {
+                return 'B';
+            }
+
             if (feature.Allocation.Value == 100 || GetBucket(_userDataRepo.GetUserId(), feature.FeatureToken, 100) <= feature.Allocation)
             {
                 var bucket = GetBucket(_userDataRepo.GetUserId(), feature.RunToken, 2);