Use value object for spout items #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, spouts would implement Iterator interface and individual items’ data could be accessed by iterating the spout object and calling its methods. With this change, each spout has getItems() method that returns an Iterator of Item objects for each item. This is much cleaner design and having separate object for each source item allows for handling them independently even after iteration switched to a next step.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, spouts would implement Iterator interface and individual items’ data could be accessed by iterating the spout object and calling its methods.
With this change, each spout has getItems() method that returns an Iterator of Item objects for each item.
This is much cleaner design and having separate object for each source item allows for handling them independently even after iteration switched to a next step.