Refactor metrics #32
Merged
Refactor metrics #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elldritch
approved these changes
Jan 18, 2024
|
|
||
| if mh.Reservation() != nil { | ||
| if err := m.StatsDClient().Timing(m.PrefixMetricName("succeeded.time"), time.Duration(time.Since(mh.Reservation().ReservedAt())), tags, 1); err != nil { | ||
| util.Warnf("unable to submit metric: %v", err) | ||
| } | ||
| if err := m.StatsDClient().Timing("faktory.jobs.processed", time.Duration(time.Since(mh.Reservation().ReservedAt())), tags, 1); err != nil { |
There was a problem hiding this comment.
I don't think so. If it were a Gauge then we'd only have metrics about how long the most recently completed task ran for. I'd rather have a histogram so that we can see the distribution of runtimes for each task type / queue.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAT-189 PLAT-463 PLAT-482
Metrics have been refactored so that they are namespaced under
faktory.rather than a configurable value. Per-queue metrics have been replaced with a single metric with aqueuelabel.The existing metrics have been maintained so that we can migrate our Datadog monitors and dashboards without downtime.
New metrics are:
statusis one ofsuccessorfail.deadis a boolean present for failed jobs.