Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore : changed target api to 29 #502

Merged
merged 1 commit into from
Sep 15, 2019
Merged

chore : changed target api to 29 #502

merged 1 commit into from
Sep 15, 2019

Conversation

ruplsingh
Copy link
Contributor

Fixes #498

Changes: target api to 29

@ruplsingh
Copy link
Contributor Author

@adityastic please review

adityastic
adityastic requested changes Sep 15, 2019
View reviewed changes
Copy link
Collaborator

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis will fail, please make appropriate changes in travis as well. Thanks

@ruplsingh
Copy link
Contributor Author

sure

@ruplsingh
Copy link
Contributor Author

@adityastic

adityastic
adityastic approved these changes Sep 15, 2019
View reviewed changes
Copy link
Collaborator

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 🚀 🔥

@ruplsingh ruplsingh force-pushed the patch-498 branch 2 times, most recently from e7be680 to 3615e00 Compare September 15, 2019 12:40
@adityastic adityastic merged commit a3fd6b0 into fossasia:development Sep 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adityastic adityastic adityastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change target api to 29
2 participants
@ruplsingh @adityastic