Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add AlertWarning for deleting badges and cliparts #596

Merged
merged 2 commits into from
Dec 31, 2019
Merged

feat: Add AlertWarning for deleting badges and cliparts #596

merged 2 commits into from
Dec 31, 2019

Conversation

refactor-droidyy
Copy link
Member

Fixes #589

Screenshots for the change:

Badge Deletion

badge

Clipart Deletion.

ezgif com-video-to-gif

@auto-label auto-label bot added the feature label Dec 31, 2019
@refactor-droidyy
Copy link
Member Author

@adityastic please review

adityastic
adityastic approved these changes Dec 31, 2019
View reviewed changes
Copy link
Collaborator

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, just shift all the string values to strings.xml and use resources to get them

@refactor-droidyy
Copy link
Member Author

@adityastic Done:+1:

@adityastic adityastic merged commit bad0839 into fossasia:development Dec 31, 2019
@refactor-droidyy refactor-droidyy deleted the deleteAlert branch December 31, 2019 11:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adityastic adityastic adityastic approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warning dialogue is shown while deleting badge and clipart
3 participants
@refactor-droidyy @adityastic @rohitverma1999hack