-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove some space errors #235
Comments
[Deleted] |
Yeah, actually I founded that travis was causing space inconsistencies problem due to the this new line/space at EOF, and the message was pretty hard to guess what's actually wrong and I was having trouble understand that. But I just founded out that few peoples are just leaving an extra line at the end of CSSand it caused no errors. Maybe there is some issues with this. |
The space inconsistency bear suggests that at the end of the page there should be an empty line as the POSIX standard says so. @niccokunzmannn some text editors automatically implement this. We could inform the students in the read me. |
@Abhi2424shek +1 |
@jig08 so should I give PR or you guys would do it, |
What about setting that in a .editorconfig file? |
@m1guelpf have I forgot even that? wow, I worked with it for a project for intel, would give in a PR soon or will u be wanting to work. |
@Abhi2424shek I have never worked with .editorconfig files, but if you can't do it, I'll try. |
@m1guelpf I would give in a PR steady fast. |
@Abhi2424shek How's going? |
@m1guelpf I would post one today a bit busy. |
Resolves #235 Added editor config file
@Abhi2424shek @Princu7 @m1guelpf So though this is a right step, I think it is not a complete solution. |
@hemantjadon sure, we will work on more solutions to go forward .editor config can be supported by additional plugins though, but the problem is the new developers won't have them. So we need something more rational. But I added editor config so that at least half of the people could be beneficial. |
@Abhi2424shek Yes that's what i was mentioning. :) |
@hemantjadon by the way atom has those by default (new line at EOF) let me see what else can I do... |
@Abhi2424shek Oh i didn't knew that, but it doesn't support |
No it doesn't have the support |
I got a rational solution @niccokunzmann see issue #226 |
Update on this ? |
I suggest we add some instruction on README/CONTRIBUTING on how to add and edit code so that build check pass. Beginners like me have very little knowledge related to all the space inconsistence and how tabs and spaces can cause difference. Therefore it would be really helpful for them to have a set of guideline to follow. That way they can avoid this errors. A link to those guidelines could be added to Tasks so that they know something like that exist. Also it would be informative and educational if there is also explanation for each of the checks. |
@rhemon It would be informational nice suggestion +1 |
would be resolved in #599 so we could close this after it is merged. |
Coala resolved the issue for us! |
We delay PRs because someone has a space at the end of a line - which is hard to understand and find and harmless.
Please remove the following errors:
The text was updated successfully, but these errors were encountered: