Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove some space errors #235

Closed
niccokunzmann opened this issue Dec 6, 2016 · 24 comments
Closed

Remove some space errors #235

niccokunzmann opened this issue Dec 6, 2016 · 24 comments

Comments

@niccokunzmann
Copy link
Member

We delay PRs because someone has a space at the end of a line - which is hard to understand and find and harmless.

Please remove the following errors:

  • No newline at EOF
  • Trailing whitespaces
@hoangvanthien
Copy link
Member

hoangvanthien commented Dec 6, 2016

[Deleted]

@animeshsinghweb
Copy link
Member

Yeah, actually I founded that travis was causing space inconsistencies problem due to the this new line/space at EOF, and the message was pretty hard to guess what's actually wrong and I was having trouble understand that. But I just founded out that few peoples are just leaving an extra line at the end of CSSand it caused no errors. Maybe there is some issues with this.

@abishekvashok
Copy link
Member

The space inconsistency bear suggests that at the end of the page there should be an empty line as the POSIX standard says so. @niccokunzmannn some text editors automatically implement this. We could inform the students in the read me.

@jigyasa-grover
Copy link
Member

We could inform the students in the read me.

@Abhi2424shek +1

@abishekvashok
Copy link
Member

@jig08 so should I give PR or you guys would do it,

@m1guelpf
Copy link
Member

m1guelpf commented Dec 8, 2016

What about setting that in a .editorconfig file?

@abishekvashok
Copy link
Member

abishekvashok commented Dec 8, 2016

@m1guelpf have I forgot even that? wow, I worked with it for a project for intel, would give in a PR soon or will u be wanting to work.

@m1guelpf
Copy link
Member

m1guelpf commented Dec 8, 2016

@Abhi2424shek I have never worked with .editorconfig files, but if you can't do it, I'll try.

@abishekvashok
Copy link
Member

@m1guelpf I would give in a PR steady fast.

@m1guelpf
Copy link
Member

m1guelpf commented Dec 8, 2016

@Abhi2424shek How's going?

@abishekvashok
Copy link
Member

@m1guelpf I would post one today a bit busy.

@Princu7 Princu7 closed this as completed in cc9c47f Dec 9, 2016
Princu7 added a commit that referenced this issue Dec 9, 2016
Resolves #235 Added editor config file
@hemantjadon
Copy link
Contributor

@Abhi2424shek @Princu7 @m1guelpf
Don't you think writing .editorconfig is not gonna solve all the problem completely though It will help on the editors with compatible plugins installed, like I know many of the main text editors do not support this directly (atom, vscode, vs studio, sublime, textmate, notepad++, xcode) all require an extra plugin to be installed. Mainly JetBeans IDE support this natively.

So though this is a right step, I think it is not a complete solution.

@hemantjadon hemantjadon reopened this Dec 9, 2016
@abishekvashok
Copy link
Member

@hemantjadon sure, we will work on more solutions to go forward .editor config can be supported by additional plugins though, but the problem is the new developers won't have them. So we need something more rational. But I added editor config so that at least half of the people could be beneficial.

@hemantjadon
Copy link
Contributor

@Abhi2424shek Yes that's what i was mentioning. :)

@abishekvashok
Copy link
Member

@hemantjadon by the way atom has those by default (new line at EOF) let me see what else can I do...

@hemantjadon
Copy link
Contributor

hemantjadon commented Dec 10, 2016

@Abhi2424shek Oh i didn't knew that, but it doesn't support .editorconfig natively i guess?

@abishekvashok
Copy link
Member

abishekvashok commented Dec 10, 2016

No it doesn't have the support

@abishekvashok
Copy link
Member

I got a rational solution @niccokunzmann see issue #226

@jigyasa-grover
Copy link
Member

Update on this ?

@abishekvashok
Copy link
Member

@jig08 I opened a new Issue please see #414

@rhemon
Copy link
Member

rhemon commented Dec 11, 2016

I suggest we add some instruction on README/CONTRIBUTING on how to add and edit code so that build check pass. Beginners like me have very little knowledge related to all the space inconsistence and how tabs and spaces can cause difference. Therefore it would be really helpful for them to have a set of guideline to follow. That way they can avoid this errors. A link to those guidelines could be added to Tasks so that they know something like that exist.

Also it would be informative and educational if there is also explanation for each of the checks.

@abishekvashok
Copy link
Member

@rhemon It would be informational nice suggestion +1

@abishekvashok
Copy link
Member

abishekvashok commented Dec 19, 2016

would be resolved in #599 so we could close this after it is merged.

@abishekvashok
Copy link
Member

Coala resolved the issue for us!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants