Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mentor note: Please mentors read #349

Closed
m1guelpf opened this issue Dec 9, 2016 · 2 comments
Closed

Mentor note: Please mentors read #349

m1guelpf opened this issue Dec 9, 2016 · 2 comments

Comments

@m1guelpf
Copy link
Member

m1guelpf commented Dec 9, 2016

#347 introduced a function to fail Travis and warn the user if editing index.html
This was made because students wewre editing this file to add them statically, instead of editing the data fields.
Now, what if you really want to edit index.html?
You could simply ignore Travis build, but that could cause confusion, so there's another way:
Just add

<!-- Safe Edit -->

somewhere in the PR body and It will automatically hide the line and skip the test.
Thank you

@niccokunzmann
Copy link
Member

Can you add this to the maintainers.md file somewhere?

m1guelpf added a commit that referenced this issue Dec 11, 2016
@m1guelpf
Copy link
Member Author

@niccokunzmann Done. Closing this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants