-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
adding NadunYashmika to the students section #296
Conversation
@yashNadun Please solve conflicts and also change the PR name to something like "Add ...your name... to the students section" You can also see CONTRIBUTING.md for further help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Squash all your commits into one and rename it to something meaningful, such as "Adding <-your-name-> in students/mentors section"
- Also provide the link to live
gh-pages
from your forked repository or relevant screenshot for easier review. - Resolve merge conflicts, this How To Manually Fix Git Merge Conflicts (video) might be helpful.
https://yashnadun.github.io/yashnadun.github/ link for github-pages |
To add yourself to the Refer Adding to student section Other changes, I believe, were not required :) |
Sorry about that, it was a mistake |
Now I think everything is OK now! |
@yashNadun Nice. You still need to make some more changes
|
Generated by 🚫 danger |
@yashNadun Thanks for your contribution.You can have a look if your photo shows up on the page and if not, I am sure, we can find a solution. |
Adding my name(Nadun Yashmika) to gci16 site of fossasia(gci16.fossasia.org).
https://github.com/yashNadun