Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding NadunYashmika to the students section #296

Merged
merged 18 commits into from
Dec 10, 2016
Merged

adding NadunYashmika to the students section #296

merged 18 commits into from
Dec 10, 2016

Conversation

nadunys
Copy link
Contributor

@nadunys nadunys commented Dec 8, 2016

Adding my name(Nadun Yashmika) to gci16 site of fossasia(gci16.fossasia.org).
https://github.com/yashNadun

@agwisniewska
Copy link
Contributor

agwisniewska commented Dec 8, 2016

@yashNadun Please solve conflicts and also change the PR name to something like "Add ...your name... to the students section" You can also see CONTRIBUTING.md for further help.

Copy link
Member

@jigyasa-grover jigyasa-grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Squash all your commits into one and rename it to something meaningful, such as "Adding <-your-name-> in students/mentors section"
  • Also provide the link to live gh-pages from your forked repository or relevant screenshot for easier review.
  • Resolve merge conflicts, this How To Manually Fix Git Merge Conflicts (video) might be helpful.

@nadunys nadunys changed the title first after first adding my name to the students section of the gci16.fossasia.org Dec 8, 2016
@nadunys nadunys changed the title adding my name to the students section of the gci16.fossasia.org adding NadunYashmika to the students section of the gci16.fossasia.org Dec 8, 2016
@nadunys
Copy link
Contributor Author

nadunys commented Dec 8, 2016

https://yashnadun.github.io/yashnadun.github/ link for github-pages

@jigyasa-grover
Copy link
Member

To add yourself to the students section , you just need to add your picture in images folder and edit students.yml

Refer Adding to student section

Other changes, I believe, were not required :)

@nadunys
Copy link
Contributor Author

nadunys commented Dec 9, 2016

Sorry about that, it was a mistake

@nadunys
Copy link
Contributor Author

nadunys commented Dec 9, 2016

Now I think everything is OK now!

@Princu7
Copy link
Contributor

Princu7 commented Dec 9, 2016

@yashNadun Nice. You still need to make some more changes

  • Resolve the merge conflicts. If you are not sure about how to do that, you can look at the contributing guide for this project.

  • Squash the commits into one and rename it to something descriptive and clear like "adding NadunYashmika to the students section".

  • If you more assistance to any of these tasks, you can ask us here or in the slack or the gitter channel of GCI.

@nadunys nadunys changed the title adding NadunYashmika to the students section of the gci16.fossasia.org adding NadunYashmika to the students section Dec 9, 2016
@checkbot
Copy link

2 Warnings
⚠️ Please provide a summary in the Pull Request description, containing, at less, your live link.
⚠️ Please add your live link to the PR body.
1 Message
📖 Hi @yashNadun thank you for your submission at Fossasia’s GCI 2016 website. Please correct any issues above, if any.

Generated by 🚫 danger

@niccokunzmann niccokunzmann merged commit 30ff79d into fossasia:gh-pages Dec 10, 2016
@niccokunzmann
Copy link
Member

niccokunzmann commented Dec 10, 2016

@yashNadun Thanks for your contribution.You can have a look if your photo shows up on the page and if not, I am sure, we can find a solution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants