Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

apurvjainblog.jpg #356

Merged
merged 5 commits into from
Dec 11, 2016
Merged

apurvjainblog.jpg #356

merged 5 commits into from
Dec 11, 2016

Conversation

ApurvJain123
Copy link
Contributor

@checkbot
Copy link

checkbot commented Dec 10, 2016

1 Message
📖 Hi @ApurvJain123 thank you for your submission at Fossasia’s GCI 2016 website. Please correct any issues above, if any.

Generated by 🚫 danger

@ankitrgadiya
Copy link
Member

Hey, @ApurvJain123
You will also have to edit a file called _data/blogs.yml and add your info there.
After editing push again and it will show here.
Checks are failing but its not because of you so don't worry about that.

@jigyasa-grover
Copy link
Member

Read gci16.fossasia.org#blog-post to know about adding your blog-post to the website.

@ankitrgadiya
Copy link
Member

@apoorvk You have to add your info in the already existing files, you dont have to create your own.

@niccokunzmann
Copy link
Member

@ApurvJain123 What are your thoughts? How would you like to go on. If you have any quastion, please ask me.

@ApurvJain123
Copy link
Contributor Author

It was my task to create PR on GC16 FOSSASIA but sometimes I got confused so there was problem but I will correct it. :)

@rhemon
Copy link
Member

rhemon commented Dec 11, 2016

@ApurvJain123 at line 94 can you add a space after article_link: and there are some other build fails.
I have resolved merge conflict for you.

@rhemon
Copy link
Member

rhemon commented Dec 11, 2016

and whats the purpose of the About_Me file?

@ApurvJain123
Copy link
Contributor Author

ApurvJain123 commented Dec 11, 2016 via email

@ApurvJain123 ApurvJain123 changed the title apurvjainblog.jpg Apurv Jain Blog Dec 11, 2016
@ApurvJain123 ApurvJain123 changed the title Apurv Jain Blog apurvjainblog.jpg Dec 11, 2016
@ApurvJain123
Copy link
Contributor Author

How to merge it.

@niccokunzmann niccokunzmann reopened this Dec 11, 2016
@niccokunzmann niccokunzmann merged commit 3852255 into fossasia:gh-pages Dec 11, 2016
@niccokunzmann
Copy link
Member

@ApurvJain123 I merged it. You can look at the website and see if everything is right. If not, you can create an issue or a new pull-request.

@niccokunzmann
Copy link
Member

If you like to do me a favor: The png file is quite large. 0.2mb. Can you try if jpg is smaller? Maybe not it is not. I do not know.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants