Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed text overflow issues resolves #373 and #130 #416

Merged
merged 1 commit into from
Dec 11, 2016
Merged

Fixed text overflow issues resolves #373 and #130 #416

merged 1 commit into from
Dec 11, 2016

Conversation

abishekvashok
Copy link
Member

@abishekvashok abishekvashok commented Dec 11, 2016

These errors where looming large so I thought I could get a fix.

Current screenshot: [gci16.fossasia.org]
image

I can't provide the preview beacuse I am on another branch @jig08 please understand.

These errors where looming large so I thought I could get a fix.
@checkbot
Copy link

1 Warning
⚠️ Please add your live link or a preview screenshot to the PR body.
1 Message
📖 Hi @Abhi2424shek thank you for your submission at Fossasia’s GCI 2016 website. Please correct any issues above, if any.

Generated by 🚫 danger

@jigyasa-grover
Copy link
Member

jigyasa-grover commented Dec 11, 2016

@Abhi2424shek

  • Provide the link to live gh-pages from your forked repository or relevant screenshot for easier review.

@abishekvashok
Copy link
Member Author

abishekvashok commented Dec 11, 2016

I am sorry @jig08 I provided the link. :) Please review

@jigyasa-grover
Copy link
Member

Verify the link above, there's a semi-colon 😉

@abishekvashok
Copy link
Member Author

@jig08 upsss sorry updated.

@jigyasa-grover
Copy link
Member

Also, a before-after screenshot shall be appreciated.

@abishekvashok
Copy link
Member Author

Sorry wait I am on another branch, @jig08

@jigyasa-grover jigyasa-grover merged commit 495fb94 into fossasia:gh-pages Dec 11, 2016
@abishekvashok
Copy link
Member Author

see the preview now :) thanks for merging @jig08
image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants