Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: replace deprecated resourceConfigurations #2654

Conversation

rahul31124
Copy link
Contributor

@rahul31124 rahul31124 commented Mar 17, 2025

Fixes #2649

Changes

Replaced deprecated resourceConfigurations with androidResources.localeFilters in build.gradle.kts.

Screenshots / Recordings

NA

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Enhancements:

  • Replaces deprecated resourceConfigurations with androidResources.localeFilters in build.gradle.kts.

Copy link

sourcery-ai bot commented Mar 17, 2025

Reviewer's Guide by Sourcery

This pull request addresses the deprecation of resourceConfigurations by replacing it with androidResources.localeFilters in the build.gradle.kts file. This change ensures that the project uses the recommended approach for configuring locale filters.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced the deprecated resourceConfigurations with androidResources.localeFilters to configure locale filters.
  • Replaced resourceConfigurations += setOf("en", "ru", "ar", "si", "pl") with androidResources { localeFilters.addAll(listOf("en", "ru", "ar", "si", "pl")) }.
app/build.gradle.kts

Assessment against linked issues

Issue Objective Addressed Explanation
#2649 Replace the deprecated resourceConfigurations element in build.gradle.kts with androidResources.localeFilters.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the list of locales to a constant to improve readability and maintainability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rahul31124 rahul31124 changed the title fix-resource-configurations-deprecation fix: resource-configurations-deprecation Mar 17, 2025
Copy link

@AsCress AsCress changed the title fix: resource-configurations-deprecation fix: replace deprecated resourceConfigurations Mar 18, 2025
@AsCress AsCress enabled auto-merge (squash) March 18, 2025 12:50
Copy link
Collaborator

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rahul31124 ! Thank you very much !

@AsCress AsCress merged commit 019928d into fossasia:development Mar 18, 2025
6 of 8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.gradle.kts contains deprecated element rescourceConfigurations
2 participants