Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: removed unused Google Maps Key #2657

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

Wassaf001
Copy link
Contributor

@Wassaf001 Wassaf001 commented Mar 22, 2025

Fixes #2639

Changes

  • Removed Google Maps Key from gradle.properties

Screenshots / Recordings

Screenshot 2025-03-23 at 2 54 26 AM

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Chores:

  • Remove Google Maps API key from gradle.properties.

Copy link

sourcery-ai bot commented Mar 22, 2025

Reviewer's Guide by Sourcery

This pull request removes the Google Maps API key from the gradle.properties file. This was done by deleting the google_key property.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the Google Maps API key from the gradle.properties file.
  • Deleted the google_key property.
gradle.properties

Assessment against linked issues

Issue Objective Addressed Explanation
#2639 Remove the exposed Google Maps API key from the gradle.properties file.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Wassaf001 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using environment variables or a secrets management solution to store the Google Maps key instead of removing it entirely.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@AsCress AsCress changed the title fix: Removed Google Maps Key fix: removed unused Google Maps Key Mar 23, 2025
@AsCress AsCress added the Fix Solution to an existing issue in app label Mar 23, 2025
@AsCress AsCress enabled auto-merge (squash) March 23, 2025 17:39
Copy link
Collaborator

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much !

@AsCress AsCress merged commit d7b9297 into fossasia:development Mar 23, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Key is Exposed.
2 participants