fix: #2398 Migrate the project to support Androidx #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheerajkotwani
changed the title
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 01807c7. Here's the output:
|
|
@dheerajkotwani fix the circle ci build |
|
@atm1504 fixed the ci build. |
|
@dheerajkotwani Squash all the commits into a single commit. |
liveHarshit
approved these changes
Jan 24, 2020
| @@ -24,6 +24,7 @@ import timber.log.Timber | |||
| * Created by collinx on 22-10-2017. | |||
| */ | |||
|
|
|||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
androidx.test.runner.AndroidJUnit4 was showing deprecation there and without this the circle ci build was also failing.
There was a problem hiding this comment.
There should be another way
There was a problem hiding this comment.
okay @liveHarshit I will try this with some different approach
There was a problem hiding this comment.
@liveHarshit made the changes as asked by you
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398 : Migrate the project to support Androidx
Changes: Migrated the project and changed the features to support androidx