-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add float for intervals + Add NetSpeed Compact and TotalNetSpeed #100
Conversation
…mething like that
Just copied some code and did some here and their things
TO make PR easy
The PR looks ok from a quick read. However remember KiB is not the same as KB ... different number of bytes. Think probably a separate option is needed to change the calculation of KiB vs KB for example - that's a different issue. So if you can back out those changes please I can merge. |
Sure Maybe in one or two days, I will get back to you when I'm done. 👍 |
DONE :), I tried my best to make a method or function of common code but I couldn't, else everything is perfect I think. PS : used 1KB = 1000B |
This comment has been minimized.
This comment has been minimized.
Are You their? @fossfreedom |
LGTM - thanks! |
This PR is for adding that functionality of floats in intervals, also it will not impact performance cause anyone cannot enter value less than 1 sec(< 1 sec was causing the real performance issue).
Second thing I added was Compact net Speed which basically is UP+DOWN and Total net speed with sigma in front of it which basically is TOTAL UP+TOTAL DOWN, which will help users to track their download and upload speed more effectively. Below is the preview in ubuntu budgie
IMO MiB and GiB looks ugly so if you can simply rename them to MB or GB that can be good but again its personal opinion , I have included this in this PR. I have also changed conversion rate from 1MiB=1024 KiB to 1MB = 1024KB