Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Add ADR for Python fm-training-estimator #10

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

aluu317
Copy link
Collaborator

@aluu317 aluu317 commented Oct 21, 2024

Defines an ADR (Architecture Decision Record) for exposing fm-training-estimator as a Python library and high level design of input and output types to the main 4 functions the library will provide

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
This reverts commit 046a295.

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
…r image

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
@aluu317 aluu317 marked this pull request as ready for review October 21, 2024 22:11
Copy link
Collaborator

@ChanderG ChanderG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aluu317
Copy link
Collaborator Author

aluu317 commented Oct 23, 2024

@ChanderG I don't have write access to merge. Please merge when you get a chance

@praveenj83
Copy link
Collaborator

I gave you access, @aluu317. Can you please try now? I need to figure out the groups and allow our full team access, but at least you should have access now.

@aluu317
Copy link
Collaborator Author

aluu317 commented Oct 23, 2024

@praveenj83 It still says Only those with write access to this repository can merge pull requests. for me

@aluu317 aluu317 merged commit 19d8d88 into foundation-model-stack:main Oct 23, 2024
1 check passed
@aluu317 aluu317 deleted the api_adr branch October 23, 2024 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants