-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: Add support and unit tests for handling of multiple files passed as a pattern in data_config #416
Closed
Abhishek-TAMU
wants to merge
7
commits into
foundation-model-stack:main
from
Abhishek-TAMU:pattern_files
Closed
test: Add support and unit tests for handling of multiple files passed as a pattern in data_config #416
Abhishek-TAMU
wants to merge
7
commits into
foundation-model-stack:main
from
Abhishek-TAMU:pattern_files
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Thanks for making a pull request! 😃 |
Thanks for making a pull request! 😃 |
1 similar comment
Thanks for making a pull request! 😃 |
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Abhishek-TAMU
changed the title
test: Add unit tests to test handling of multiple files passed via pattern in data_config
test: Add support and unit tests for handling of multiple files passed via pattern in data_config
Dec 12, 2024
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Abhishek-TAMU
requested review from
anhuong,
Ssukriti,
aluu317,
fabianlim and
kmehant
as code owners
December 13, 2024 16:49
Abhishek-TAMU
changed the title
test: Add support and unit tests for handling of multiple files passed via pattern in data_config
test: Add support and unit tests for handling of multiple files passed as a pattern in data_config.
Dec 13, 2024
Abhishek-TAMU
changed the title
test: Add support and unit tests for handling of multiple files passed as a pattern in data_config.
test: Add support and unit tests for handling of multiple files passed as a pattern in data_config
Dec 13, 2024
2 tasks
Moved to PR: #424 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added unit test for testing handling of multiple files passed as a pattern in
data_config
yaml file.List of supported/not supported examples for the feature of passing files via pattern:
Not supported: Passing all files of the directory with
/*
without mentioning the type of extensionFor example:
/path/to/directory/*
Supported: Passing all files of the directory with
/*
along with mentioning the type of extensionFor example:
/path/to/directory/*.json
OR/path/to/directory/*.arrow
OR/path/to/directory/*.parquet
Not supported: Passing files of the directory which matches any pattern for example
*input_output*
without mentioning the type of extension. For example:/path/to/folder/*input_output*
Supported: Passing files of the directory which matches any pattern for example
*input_output*
along with mentioning the type of extension.For example:
/path/to/folder/*input_output*.json
OR/path/to/folder/*input_output*.parquet
OR/path/to/folder/*input_output*.arrow
Related issue number
https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1487
How to verify the PR
Verify unit test additions.
Was the PR tested