Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Add support and unit tests for handling of multiple files passed as a pattern in data_config #416

Closed

Conversation

Abhishek-TAMU
Copy link
Collaborator

@Abhishek-TAMU Abhishek-TAMU commented Dec 12, 2024

Description of the change

Added unit test for testing handling of multiple files passed as a pattern in data_config yaml file.

List of supported/not supported examples for the feature of passing files via pattern:

Not supported: Passing all files of the directory with /* without mentioning the type of extension
For example: /path/to/directory/*

Supported: Passing all files of the directory with /* along with mentioning the type of extension
For example: /path/to/directory/*.json OR /path/to/directory/*.arrow OR /path/to/directory/*.parquet

Not supported: Passing files of the directory which matches any pattern for example*input_output* without mentioning the type of extension. For example: /path/to/folder/*input_output*

Supported: Passing files of the directory which matches any pattern for example *input_output* along with mentioning the type of extension.
For example: /path/to/folder/*input_output*.json OR /path/to/folder/*input_output*.parquet OR /path/to/folder/*input_output*.arrow

Related issue number

https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1487

How to verify the PR

Verify unit test additions.

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Abhishek-TAMU and others added 5 commits December 10, 2024 16:24
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the test label Dec 12, 2024
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

1 similar comment
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
@Abhishek-TAMU Abhishek-TAMU changed the title test: Add unit tests to test handling of multiple files passed via pattern in data_config test: Add support and unit tests for handling of multiple files passed via pattern in data_config Dec 12, 2024
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
@Abhishek-TAMU Abhishek-TAMU marked this pull request as ready for review December 13, 2024 16:49
@Abhishek-TAMU Abhishek-TAMU changed the title test: Add support and unit tests for handling of multiple files passed via pattern in data_config test: Add support and unit tests for handling of multiple files passed as a pattern in data_config. Dec 13, 2024
@Abhishek-TAMU Abhishek-TAMU changed the title test: Add support and unit tests for handling of multiple files passed as a pattern in data_config. test: Add support and unit tests for handling of multiple files passed as a pattern in data_config Dec 13, 2024
@Abhishek-TAMU
Copy link
Collaborator Author

Moved to PR: #424

@Abhishek-TAMU Abhishek-TAMU deleted the pattern_files branch December 19, 2024 21:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants