Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Menu Destroy method doesn't remove all classes #11467

Closed
geosigno opened this issue Aug 22, 2018 · 1 comment · Fixed by #11469
Closed

Menu Destroy method doesn't remove all classes #11467

geosigno opened this issue Aug 22, 2018 · 1 comment · Fixed by #11469
Labels
🐛bug menu PR open

Comments

@geosigno
Copy link

It appears that when I destroy a dropdown menu and replace it by a accordion menu, the class .is-dropdown-submenu-item is still here.

So my custom style applied on this class is in conflict when the accordion is set.

I created a CodePen: https://codepen.io/anon/pen/MqYqYR?editors=1111

The class .is-dropdown-submenu-item is still has a red color applied. Even when I destroy the dropdown and add a accordion instead, the class (and the red color) are still here.

Just click on "witch from dropdown to accordion the menu" to switch between menu.

The same issue is appearing for all type of menu. (dropdown, accordion, drilldown)
@geosigno geosigno changed the title Menu Destory Method doesn't remove all classes Menu Destroy method doesn't remove all classes Aug 22, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this issue Aug 22, 2018
@ncoden
fix: clear submenu item classe in Nest foundation#11467
fcd02bd 
Closes foundation#11467
@ncoden ncoden mentioned this issue Aug 22, 2018
Merged
12 tasks
@ncoden
Copy link
Contributor

ncoden commented Aug 22, 2018

Fixed in #11469

@ncoden ncoden added the PR open label Aug 22, 2018
ncoden added a commit that referenced this issue Aug 24, 2018
@ncoden
Merge pull request #11469 from ncoden/fix/clear-nest-submenu-classes-…
0d6f535 
…11467

fix: clean submenu items classes in Nest #11467
@ncoden ncoden mentioned this issue Aug 24, 2018
Closed
4 tasks
ncoden added a commit to ncoden/foundation-sites that referenced this issue Aug 25, 2018
@ncoden
Use pull request foundation#11469 from ncoden/fix/clear-nest-submenu-…
58b8dd8 
…classes-11467 for v6.5.0

fcd02bd fix: clear submenu item classe in Nest foundation#11467

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this issue Sep 10, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
🐛bug menu PR open
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clean submenu items classes in Nest #11467 ncoden/foundation-sites
2 participants
@geosigno @ncoden