-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Setting XY Grid gutter to 0 breaks margin offset #11471
Labels
Comments
Hi @hexagoncircle 👋 , Thank you for the bug report. It has been resolved in #11472. We were using the fix you suggested (not using Feel free to review the pull request to ensure it is what you expected. |
ncoden
added a commit
that referenced
this issue
Aug 26, 2018
…11471 fix: fix offset when gutters are 0 in "xy-cell-offset" #11471
Thanks, @ncoden - that was fast! I have reviewed this locally and it works as expected. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this issue
Sep 10, 2018
…-margin-11471 for v6.5.0 281e4a8 fix: fix generated offset for zero gutters in "xy-cell-offset" foundation#11471 c07d3d9 fix: fix offset calculation in "xy-cell-offset" Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
What should happen?
xy-cell-offset
with offset valueWhat happens instead?
Outputs invalid declaration:
Possible Solution
If value is 0, output property value without calc()
Test Case and/or Steps to Reproduce
Note - This test will not work in Codepen without having the mixins available so I've added the actual CSS rendered as well as my expected result.
Test Case: https://codepen.io/hexagoncircle/pen/3301fc285292192524930c01f3eab938/
Context
I need a grid without gutters. It would be preferred to set this up with the provided Sass mixins instead of using Foundation classes in HTML.
Your Environment
Checklist (all required):
The text was updated successfully, but these errors were encountered: