Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tabs deep-linking with data-tabs-target set the wrong url #11484

Closed
3 tasks done
ncoden opened this issue Aug 31, 2018 · 0 comments · Fixed by #11485
Closed
3 tasks done

Tabs deep-linking with data-tabs-target set the wrong url #11484

ncoden opened this issue Aug 31, 2018 · 0 comments · Fixed by #11485
Labels
🐛bug PR open Tabs

Comments

@ncoden
Copy link
Contributor

ncoden commented Aug 31, 2018 •
edited
Loading

What should happen?

When using Tabs with deep-linking and a custom target data-tabs-target, the history should be updated/replaced with the target when opening a tab.

What happens instead?

The href attribute of the tab is always used to update/replace the history, even with a custom target data-tabs-target set. So the history may be updated/replaced with the wrong url, or not updated/replaced at all because it points to an other domain.

Test Case and/or Steps to Reproduce (for bugs)

Test Case: https://codepen.io/ncoden/pen/wEgbqM

Your Environment

  • Foundation version(s) used: v6.5.0-rc.2
  • Browser(s) name and version(s): Firefox 61.0.2
  • Device, Operating System and version: macOs 10.13.6

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • There are no other issues similar to this one.
  • The issue title and template are correctly filled.
ncoden added a commit to ncoden/foundation-sites that referenced this issue Aug 31, 2018
@ncoden
fix: use data-tabs-target to update history in Tabs deep-linking foun…
f974a5b 
…dation#11484

Closes foundation#11484
@ncoden ncoden mentioned this issue Aug 31, 2018
Merged
9 tasks
@ncoden ncoden added the PR open label Aug 31, 2018
ncoden added a commit that referenced this issue Sep 3, 2018
@ncoden
Merge pull request #11485 from ncoden/fix/tabs-deep-link-custom-targe…
1017fc7 
…t-11484

fix: use data-tabs-target to update history in Tabs deep-linking #11484
ncoden added a commit to ncoden/foundation-sites that referenced this issue Sep 10, 2018
@ncoden
Use pull request foundation#11485 from ncoden/fix/tabs-deep-link-cust…
a6a360e 
…om-target-11484 for v6.5.0

f974a5b fix: use data-tabs-target to update history in Tabs deep-linking foundation#11484

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this issue Sep 10, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
🐛bug PR open Tabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use data-tabs-target to update history in Tabs deep-linking #11484 ncoden/foundation-sites
1 participant
@ncoden