Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Dropdown] Horizontal position does not work with additional classes #8572

Closed
maggo opened this issue Apr 11, 2016 · 1 comment
Closed

[Dropdown] Horizontal position does not work with additional classes #8572

maggo opened this issue Apr 11, 2016 · 1 comment
Labels
javascript

Comments

@maggo
Copy link
Contributor

maggo commented Apr 11, 2016

When adding classes after float-left/right the regex in foundation.dropdown.js#L74 will no longer read the horizontal position correcly. The matched string will be everything till the last space, see this RegexPal example

Testing for float-left and float-right explicitly or writing the regex like /float-(\S+)\s/ should fix this.
ncoden added a commit to ncoden/foundation-sites that referenced this issue Apr 11, 2016
@ncoden
[Dropdown] Fix horizontal position with additional classes foundation…
8a2cde2 
…#8572

Fix foundation#8572
> [Dropdown] Horizontal position does not work with additional classes
@ncoden ncoden mentioned this issue Apr 11, 2016
Merged
@ncoden
Copy link
Contributor

ncoden commented Apr 11, 2016

Pull request: #8579

kball added a commit that referenced this issue Apr 12, 2016
@kball
Merge pull request #8579 from ncoden/fix-dropdown-position-classes
eefc4f7 
[Dropdown] Fix horizontal position with additional classes #8572
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maggo @andycochran @ncoden