Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

.button-group buttons do not wrap as expected with flexbox enabled #9325

Closed
johnbacon opened this issue Nov 2, 2016 · 6 comments · Fixed by #11871
Closed

.button-group buttons do not wrap as expected with flexbox enabled #9325

johnbacon opened this issue Nov 2, 2016 · 6 comments · Fixed by #11871

Comments

@johnbacon
Copy link
Contributor

.button-group components without flexbox enabled: http://codepen.io/johnbacon/pen/ZBzXMr
.button-group components with flexbox enabled: http://codepen.io/johnbacon/pen/gLYGBa

This appears to be due to the following: https://github.com/zurb/foundation-sites/blob/b1d99bb184d2bb8fb1ed2951c3e5ab8fb4f3a9d9/scss/components/_button-group.scss#L39

nowrap is the default value of flex-wrap, so I do not believe this needs to be specified at all in _button-group.scss. However, changing that value to wrap produces the expected result (consistent with non-flexbox): http://codepen.io/johnbacon/pen/eBOGbr

@rafibomb
Copy link
Member

rafibomb commented Feb 2, 2017

Hmmm, adding

.button-group {
  flex-wrap: wrap;
}

Seems to do the trick as you said. This might be as simple as adding this property and value to the .button-group parent. Are you able to submit a PR for it? We'd merge it in.

@canterberrie
Copy link
Contributor

Hey, this is going to be fixed in a PR for fixing button group spacing. You can see the commit here: 22f33f0#diff-d0689b3f481699857ae2680a820ff6aaR39

@glen-84
Copy link
Contributor

glen-84 commented Sep 22, 2017

@canterberrie Any news regarding this issue?

@IamManchanda
Copy link
Contributor

@colin-marshall
Copy link
Contributor

Paging @rafibomb

@DanielRuf
Copy link
Contributor

Still not fixed. https://codepen.io/DanielRuf/pen/rNByzMo

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants