-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
.button-group buttons do not wrap as expected with flexbox enabled #9325
Comments
Hmmm, adding
Seems to do the trick as you said. This might be as simple as adding this property and value to the |
Hey, this is going to be fixed in a PR for fixing button group spacing. You can see the commit here: 22f33f0#diff-d0689b3f481699857ae2680a820ff6aaR39 |
@canterberrie Any news regarding this issue? |
@rafibomb what's the status of this branch |
Paging @rafibomb |
Still not fixed. https://codepen.io/DanielRuf/pen/rNByzMo |
.button-group
components without flexbox enabled: http://codepen.io/johnbacon/pen/ZBzXMr.button-group
components with flexbox enabled: http://codepen.io/johnbacon/pen/gLYGBaThis appears to be due to the following: https://github.com/zurb/foundation-sites/blob/b1d99bb184d2bb8fb1ed2951c3e5ab8fb4f3a9d9/scss/components/_button-group.scss#L39
nowrap
is the default value offlex-wrap
, so I do not believe this needs to be specified at all in_button-group.scss
. However, changing that value towrap
produces the expected result (consistent with non-flexbox): http://codepen.io/johnbacon/pen/eBOGbrThe text was updated successfully, but these errors were encountered: