Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: resolve flebox button group bug #11871

Merged
merged 3 commits into from
Feb 3, 2020
Merged

fix: resolve flebox button group bug #11871

merged 3 commits into from
Feb 3, 2020

Conversation

DanielRuf
Copy link
Contributor

Description

...

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf changed the title Feature/buttongroup flex fix: resolve flebox button group bug Oct 19, 2019
@DanielRuf
Copy link
Contributor Author

We should reword the commits to follow our commitlint rules.

@DanielRuf DanielRuf mentioned this pull request Oct 19, 2019
Closed
3 tasks
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@DanielRuf DanielRuf requested a review from a team January 13, 2020 22:57
@weekly-digest weekly-digest bot mentioned this pull request Jan 19, 2020
Closed
joeworkman
joeworkman approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@joeworkman joeworkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one.

@joeworkman joeworkman merged commit 7753edc into develop Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@DanielRuf DanielRuf deleted the feature/buttongroup-flex branch March 28, 2020 22:29
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-6-6-2/1936/1

This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
@AliceSof AliceSof mentioned this pull request Aug 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joeworkman joeworkman joeworkman approved these changes

Assignees
No one assigned
Labels
Button Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.button-group buttons do not wrap as expected with flexbox enabled
2 participants
@DanielRuf @joeworkman