feat: add opening methods to responsiveAccordionTabs #10953

[ncoden]

Changes:

• make ResponsiveAccordionTabs using its options
• add open/close/toggle methods to responsiveAccordionTabs

Closes #10953

Note: open/toggle methods are not supported in tabs mode.

[DanielRuf]

Will test tomorrow.

[DanielRuf]

Seems fine so far. But what about historyHandled and firstTime?

[ncoden]

Actually I still need to work on this. At least to improve the API for tabs. It is a bit difficult to understand what you need to pass to open between the tab and accordion markum.

So I'll take a look at historyHandled and firstTime too.

[DanielRuf]

Do we also need some unit tests then?

[ncoden]

Yes, there's never enough unit tests ;)

[DanielRuf]

So I'll take a look at historyHandled and firstTime too.

Any news on this?

[ncoden]

No, just need some time to work on this.

[DanielRuf]

Is data-active-collapse="true" also relevant here?

[DanielRuf]

Bump =)

[ncoden]

I seen your message but as you can see this is new features planned for v6.6.0 so I'll not spend more time on this for now. There's enough work with getting v6.5.0 released. You can consider all v6.6.0 PR as freezed until v6.5.0 is out.

Thx for the bump anyway =)

[DanielRuf]

Ah ok, was not quite clear from the changes in the comment section, only on the right side.

[DanielRuf]

Tested with patch-package in 6.4.3, works great.

[ayyobro]

doot. Would be cool to have this merged soon!

[kball]

@DanielRuf it looks like you reviewed and tested this, is it good to merge?

[DanielRuf]

Not sure but a few things are missing but I think it can be merged as it implements most of the currently missing things.

#10961 (comment)

[kball]

OK based on prior comment going to merge this

[joeworkman]

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1