docs: use named imports in javascript documentation #11497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamManchanda
approved these changes
Sep 9, 2018
| import Dropdown from 'foundation-sites/js/foundation.dropdown'; | ||
| import DropdownMenu from 'foundation-sites/js/foundation.dropdownMenu'; | ||
| import { Dropdown } from 'foundation-sites/js/foundation.dropdown'; | ||
| import { DropdownMenu } from 'foundation-sites/js/foundation.dropdownMenu'; |
There was a problem hiding this comment.
Confimed with the export code too
- https://github.com/zurb/foundation-sites/blob/develop/js/foundation.dropdown.js#L431
- https://github.com/zurb/foundation-sites/blob/develop/js/foundation.dropdownMenu.js#L483
Merging it...
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Sep 10, 2018
…th for v6.5.0 c7a0b9c docs: use named import for javascript "direct import" fallback Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Nov 22, 2018
Despite the previous attempts to make Foundation compatible with tree shaking (foundation#11445, foundation#11497 and foundation#11508), Foundation is used with side-effects (on jQuery) and cannot be considered as "without side-effects" for tree-shaking purposes. This commit remove the "sideEffects: false" label and thus disable tree-shaking support, until the Foundation API and usage is changed to not implicitely rely on the global jQuery object. Closes foundation#11586 Related to: - foundation#11508 - foundation#11497 - foundation#11445
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Nov 22, 2018
Despite the previous attempts to make Foundation compatible with tree shaking (foundation#11445, foundation#11497 and foundation#11508), Foundation is used with side-effects (on jQuery) and cannot be considered as "without side-effects" for tree-shaking purposes. This commit remove the "sideEffects: false" label and thus disable tree-shaking support, until the Foundation API and usage is changed to not implicitely rely on the global jQuery object. Closes foundation#11586 Related to: - foundation#11508 - foundation#11497 - foundation#11445
9 tasks
This was referenced Apr 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default imports were removed from plugins in #11445. This pull request use named import for the "direct import" fallback in the JavaScript tree-shaking documentation, instead of default imports.
Types of changes
Checklist
developordevelop-v...).I have added tests to cover my changes (if relevant).