Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update prototyping-utilities.md #11500

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Update prototyping-utilities.md #11500

merged 3 commits into from
Sep 13, 2018

Conversation

chrisdfe
Copy link
Contributor

Description

Removed an unnecessary apostrophe in the description there.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

Removed an unnecessary apostrophe in the description there
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrisdfe 👋,

I have an idea about what the whole sentence should mean, but "into hi-fi coded prototypes ultra fast." look like words were put in the wrong order.

I am missing something? I'm not a native english speaker.

@chrisdfe
Copy link
Contributor Author

Hi @ncoden!
I see what you mean - that whole sentence is a little confusing. The apostrophe in "prototypes" was definitely incorrect grammar though.

Do you think this reads any better?
"These optional classes and mixins are great for quickly turning sketches and mockups into hi-fi coded prototypes."

@ncoden
Copy link
Contributor

ncoden commented Sep 12, 2018

@chrisdfe Yes this is way better, thank you! Could you provide a commit for this?

Reworded part of the description
@chrisdfe
Copy link
Contributor Author

👍

@@ -1,6 +1,6 @@
---
title: Prototyping Utilities
description: Quickly prototype layouts and UI with Foundation's Prototyping Utilities. These optional classes and mixins are great realizing your sketches and mockups into hi-fi coded prototype's ultra fast.
description: Quickly prototype layouts and UI with Foundation's Prototyping Utilities. These optional classes and mixins are great for quickly turning sketches and mockups into hi-fi coded prototypes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an English native speaker either but the hi-fi sounds really weird to me.
I would just write and mockups into coded prototypes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants