-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add support of [formnovalidate] in Abide #11613
feat: add support of [formnovalidate] in Abide #11613
Conversation
Besides I've added an enableValidation method to set isEnabled via JS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SassNinja 👋,
Thank you for the pull request!
I have some remarks though regarding of the implementation.
@ncoden thanks for your review! I've commented each of your remarks. |
@SassNinja Could you add unit tests after we agreed on the expected behavior of the form at #11613 (review) ? 😄 |
This makes sure Abide behaves identical to a native form with formnovalidate submit.
the code has changes in the meantime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looking good - a couple quick notes/questions but I don't think they block merging.
This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there: https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1 |
Description
This PR adds
formnovalidate
support to Abide. Precisely it checks for[type="submit"][formnovalidate]
and disables the whole validation if clicked (emulates the native behavior https://www.w3schools.com/tags/att_input_formnovalidate.asp)In the course of this I've added the method
enableValidation
that provides an easy way to enable/disable the validation.Types of changes
Checklist
develop
ordevelop-v...
).