Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: remove duplicate code in util.nest #11636

Merged
merged 1 commit into from Dec 23, 2018
Merged

refactor: remove duplicate code in util.nest #11636

merged 1 commit into from Dec 23, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

This PR removes a code line which is already used a few lines later.

  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf requested a review from kball December 20, 2018 07:56
@ncoden ncoden merged commit 5946e87 into foundation:develop Dec 23, 2018
ncoden pushed a commit that referenced this pull request Jan 11, 2019
@ncoden
Use pull request #11636 from DanielRuf/refactor/util.nest-remove-dupl…
ffc6838 
…icate-code for v6.5.0

5cd6267 refactor: remove duplicate code in util.nest

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Jan 12, 2019
Merged
11 tasks
@DanielRuf DanielRuf deleted the refactor/util.nest-remove-duplicate-code branch March 17, 2019 19:26
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ncoden ncoden ncoden approved these changes

@kball kball Awaiting requested review from kball

Assignees
No one assigned
Labels
javascript utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden