Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/vertical slider handle negative data start #11663

Merged

Conversation

altras
Copy link
Contributor

@altras altras commented Jan 23, 2019

Description

In this PR we propose a fix for Vertical Slider to handle negative data-start values. The change is isolated in _value and _setHandlePos.

I appreciate your feedback 🙇

motivation

Having a negative data-start value extends the use cases for the Slider.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@kball
Copy link
Contributor

kball commented Jul 24, 2019

I have tested this in isolation, as well as reviewed the code. Merging.

@kball kball merged commit 21e6e16 into foundation:develop Jul 24, 2019
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants