Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: use correct event name - closes #11989 #11990

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix: use correct event name - closes #11989 #11990

merged 1 commit into from
Mar 27, 2020

Conversation

iamcanadian1973
Copy link
Contributor

@iamcanadian1973 iamcanadian1973 commented Feb 7, 2020 •
edited by DanielRuf
Loading

Description

Incorrect case for dropdownmenu on line 153

https://github.com/foundation/foundation-sites/blob/develop/js/foundation.dropdownMenu.js#L153

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf force-pushed the iamcanadian1973-patch-dropdownMenu-case-fix branch from ea5d5d6 to ee6f0d9 Compare February 7, 2020 08:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@DanielRuf DanielRuf changed the title Update foundation.dropdownMenu.js ix: use correct event name - closes #11989 Feb 7, 2020
@DanielRuf DanielRuf changed the title ix: use correct event name - closes #11989 fix: use correct event name - closes #11989 Feb 7, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@joeworkman joeworkman added this to the 6.6.2 milestone Mar 27, 2020
@joeworkman joeworkman merged commit ddaa9f1 into foundation:develop Mar 27, 2020
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-6-6-2/1936/1

This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
@AliceSof AliceSof mentioned this pull request Aug 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dropdown Menu javascript
Projects
None yet
Milestone
6.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@iamcanadian1973 @joeworkman @DanielRuf