Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug #12070: make _button-group.scss compatible with libsass 3.6.3 #12419

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Bug #12070: make _button-group.scss compatible with libsass 3.6.3 #12419

merged 1 commit into from
Jul 11, 2022

Conversation

tjdub
Copy link

@tjdub tjdub commented Apr 14, 2022

Description

This change allows compilation of _button-group.scss on libsass 3.6.3. Without this change @include foundation-button-group; will cause an infinite loop on compilers which use it. For example: PHP on Ubuntu 20.04. The change simply prevents the use of 'null' from being evaluated.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

vita10gy
vita10gy approved these changes Jun 3, 2022
View reviewed changes
Copy link

@vita10gy vita10gy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed an issue we were having.

@joeworkman joeworkman merged commit 064b328 into foundation:develop Jul 11, 2022
@iamsuganthi iamsuganthi mentioned this pull request Aug 6, 2024
Open
@AliceSof AliceSof mentioned this pull request Aug 6, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vita10gy vita10gy vita10gy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjdub @vita10gy @joeworkman