Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add description for the center option... #8543

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Conversation

brettsmason
Copy link
Contributor

for grid-col-position(). Helps for 8485.

in grid-column-position()/grid-col-pos() mixin.
@@ -8,7 +8,7 @@

/// Reposition a column.
///
/// @param {Number} $position - Direction and amount to move. The column will move equal to the width of the column count specified. A positive number will push the column to the right, while a negative number will pull it to the left.
/// @param {Number} $position - Direction and amount to move. The column will move equal to the width of the column count specified. A positive number will push the column to the right, while a negative number will pull it to the left. Set to "center" (without quotes) to center the column.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks.

I have some proposals:

  • remove (without quotes), it is not necessary
  • change the argument type to {Number|Keyword}

@kball kball merged commit 6b236f2 into develop Apr 12, 2016
@kball kball deleted the grid-col-pos-center-docs branch April 20, 2017 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants