Add inline-svg icon support #8649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now display a correct message on the event "formvalid.zf.abide"
[ABIDE] Documentation : Fix message when the form is valid
|
Not everyone would like to have an SVG tangled up with their HTML. If someone wants to have an SVG supported in the menu, then they can just add their own styles without messing up the core ZF. What are those other commits in this pull request? I think they're unrelated to this Add inline-svg icon support commit you'd like to address. |
|
We use svg-icon-system for our client project. Currently we add (svg-support) for menu-icons in own styles but why not make it global ... You're right. Only the Add inline-svg icon support commit is important. |
|
The addition of SVG seems reasonable to me, but please resubmit with a clean branch that contains only that commit difference. |
|
Look at this: #8683 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.