Toggle aria-expanded on all offcanvas triggers #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. @Owlbertz do you agree? |
|
Yup. I will pull this down and have a look. |
|
@Owlbertz did you get a chance to look at this? |
|
Huh sorry, I am not assigned and therefore did not see this while filtering the issues. Doing this asap. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple elements are triggers for an off-canvas element, they all receive
aria-expanded="false"when initialized, but only the actioned trigger is updated when the menu is opened. This causes screen readers to read the wrong state of additional triggers.