fix unset var on foundation slider #8948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this affects the |
|
@jasonraimondi are you able to fix this PR changing the dist files anytime soon? There are already two duplicates of this PR and I really want to go ahead and merge it to prevent future duplicates. |
|
The dist stuff will get overwritten in release, but this does update the src as well, so it should be fine. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation slider has an unset variable where the result is the slider renders properly, but when slid the slider throws a console error stating the variable 'offsetPct' is undefined.
Please see issue #8900