Fix for resetting background color on hover and focus state of a disabled flavored button. #9022
Conversation
|
Works great for a normal download, thanks for that! But unfortunately this PR doesn't work for the custom build download. Or actually I probably should say this PR does work but somehow it is not included in the "foundation.min.css" from the custom build download. Can you take a look at it @kball ? Here is a fiddle with the CSS from the customized download of foundation.min.css |
|
@Silvester20 I just tried doing a download of the full from there and it appeared to work fine... can you give me more details about the options you used for the download? |
|
@kball Yes, I didn't made any change to the custom download. Just go to the download page and scroll to bottom and press the big orange button "Download Custom Build". Then I took the minified version of the CSS file. |
|
Thanks @Silvester20, that helped me find it. There was a caching problem in the customizer and in some cases it was still serving out 6.2.3. has been fixed. |
| opacity: $button-opacity-disabled; | ||
| cursor: not-allowed; | ||
|
|
||
| &:hover, &:focus { | ||
| background-color: $button-background; | ||
| background-color: $color; | ||
| color: $button-color; |
There was a problem hiding this comment.
Shouldn't this use foreground($color, $button-color-alt, $button-color)? if the button background color is very light? The secondary color is usually gray so we don't want the font color to be white then...
Fix for #9021