Fix #9412 - Import normalize-scss with its full path

[ncoden]

Import normalize-scss with its full path instead of including the assets path in gulp-sass.

Fix #9412

[ncoden]

Poke @kball foundation@6.3.0-rc1 is broken. This is a hotfix.

[oxyc]

This doesn't work with foundation as a NPM dependency as normalize-scss will be in the root node_modules/. I can fix it by requiring an older version of normalize-scss in my project root and thus installing foundations version within it's own node_modules/ directory.

[kball]

so... I'm a little confused about this because

1. the current build is working for me... what am I doing differently?
2. this seems to overly subscribe how your dependencies are located - what happens if someone uses a custom node modules path, or is using bower instead of npm? Paths should be a part of the build, not the src

[oxyc]

https://github.com/npm/npm/blob/ff47bc138e877835f1c0f419fea5f5672110678a/CHANGELOG.md#flat-flat-flat

So the default behaviour for foundation-sites installed as a dependency would not work unless you introduced a version conflict for normalize-scss.

[ncoden]

When Foundation is used in a Sass project via NPM or Bower, it is by importing /scss/foundation.scss, with the project build process. But /scss/foundation.scss needs its own dependencies, needs to know their path, and thus they can't be imported via NPM or Bower as real dependencies.

We have to install our Sass dependencies (like normalize-scss) via NPM only as a dev dependencies, then copy them to /scss/_vendor in the sass gulp build task. By example for normalize, it can be imported in /scss/foundation.scss with:

@import "_vendor/normalize-scss/sass/normalize";

When the package is published, the sass gulp build task is called too, and Sass dependencies are still available in /scss/_vendor.

@hugogiraudel @kball What do you think ?

[ncoden]

I close this PR. See: #9458

[KittyGiraudel]

That seems like a valid idea.

[ncoden]

@hugogiraudel Did you seen the PR ?