[WIP] Better Sass dependencies management #9542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare a better way to handle SCSS dependencies. Revert: - foundation#9430: add normalize dependency - foundation#9458: import Sass dependencies in vendor folder - foundation#9469: [TMP] Fix Sass dependencies import for Bower
Use `gulp-shopify-sass` (@ncoden’s fork) to compile SCSS files and dependencies into a distribution SCSS file `dist/scss/foundation.scss`. BREAKING CHANGE: This file should be imported into external projects instead of `scss/foundation.scss`. To import Foundation partials manually, the dependencies `normalize-scss` and `sassy-lists` should be imported before. Changes: - Add `ncoden/gulp-shopify-sass` dependency. - Add `sass:foundationSCSS` gulp task, which concat SCSS files into `_build/assets/scss/foundation.scss`. - Rename `sass:foundation` gulp task to `sass:foundationCSS`. - Update `deploy:dist` gulp task to handle SCSS dist file Other changes: - Add missing paths to include for Sass in `customiser` gulp task.
`sass:foundation` was renamed to `sass:foundationCSS
Unpin dependency `gulp-shopify-sass` from my repo and use official `v0.4.0` (the waited pull requests has been merged). Other changes: - Update yarn.lock`
|
@ncoden what is the current state of this PR? |
|
I have to:
|
|
Some news: I just added Eyeglass support for |
Merged
|
Coming back to this, @ncoden what was the status here? |
|
We have to rebase this PR. Is this still highly relevant when we switch to a pure webpack solution? |
5 tasks
|
Going to close this one out and we can rethink this for F7. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #9478
Fix: #9492
Changes:
dist/scss/foundation.scsswith dependencies included.settings.scssdeps and ensure it can be imported after Foundation.Note to myself: the
_vendorfolder was a f stupid idea. Don't do that again !