Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 #329

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 6, 2023

Bumps github.com/spf13/cobra from 1.7.0 to 1.8.0.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.8.0

✨ Features

🐛 Bug fixes

🔧 Maintenance

🧪 Testing & CI/CD

✏️ Documentation


Thank you everyone who contributed to this release and all your hard work! Cobra and this community would never be possible without all of you!!!! 🐍

Full Changelog: spf13/cobra@v1.7.0...v1.8.0

Commits
  • a0a6ae0 Improve API to get flag completion function (#2063)
  • 890302a Support usage as plugin for tools like kubectl (#2018)
  • 48cea5c build(deps): bump actions/checkout from 3 to 4 (#2028)
  • 22953d8 Replace all non-alphanumerics in active help env var program prefix (#1940)
  • 00b68a1 Add tests for flag completion registration (#2053)
  • b711e87 Don't complete --help flag when flag parsing disabled (#2061)
  • 8b1eba4 Fix linter errors (#2052)
  • 4cafa37 Allow running persistent run hooks of all parents (#2044)
  • 5c962a2 build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 (#2047)
  • efe8fa3 build(deps): bump actions/setup-go from 3 to 4 (#1934)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 6, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.8.0 branch from 1781c62 to 91f79fc Compare November 6, 2023 14:51
@vkhoroz
Copy link
Member

vkhoroz commented Nov 6, 2023

We are specifically interested in this fix: https://github.com/spf13/cobra/issues/2044

I will try to do some regression testing later this week.

@vkhoroz
Copy link
Member

vkhoroz commented Nov 14, 2023

@dependabot rebase

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.8.0 branch from 91f79fc to 85e328e Compare November 14, 2023 15:04
@vkhoroz
Copy link
Member

vkhoroz commented Nov 14, 2023

Verified that the most critical cobra functions we use work well, and that the fix we need also works spf13/cobra#2044.

@vkhoroz vkhoroz merged commit 1416f4e into main Nov 14, 2023
8 checks passed
@vkhoroz vkhoroz deleted the dependabot/go_modules/github.com/spf13/cobra-1.8.0 branch November 14, 2023 15:22
vkhoroz added a commit that referenced this pull request Nov 14, 2023
We upgraded cobra to 1.8.0 with #329.
So we can use its fix for persistent hooks traversal spf13/cobra#2044,
instead of our workaround for it from #312.

Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
vkhoroz added a commit that referenced this pull request Nov 14, 2023
We upgraded cobra to 1.8.0 with #329.
So we can use its fix for persistent hooks traversal spf13/cobra#2044,
instead of our workaround for it from #312.

Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant