fix: remove StdStorage in CommonBase contract

[graykode]

Remove StdStorage in Common.sol
If there is StdStorage in Common.sol, this testcase cant return ERROR when run with forge

pragma solidity ^0.8.0;

import "forge-std/Test.sol";

contract good is Test {
    uint256 a;

    function testAAA() public {
        uint256 id = vm.snapshot();
        a = 1;
        assertEq(a, uint256(2));
        vm.revertTo(id);
    }
}

[mds1]

Holding off on merging this per discussion in foundry-rs/foundry#3055 — let's move discussion there, cc @ZeroEkkusu if you have any thoughts on this PR

[ZeroEkkusu]

Initializing a struct before DSTest is inherited causes the example to pass.

Since it's a false positive (dangerous), let's fix the issue immediately. @graykode, could you please move TestBase to the of the inheritance chain instead:

abstract contract Test is DSTest, StdAssertions, StdCheats, StdUtils, TestBase {}

[mattsse]

agree, let's merge and I'll debug the root cause.

@mds1 probably need another patch release?

[ZeroEkkusu]

My comment was unclear: we are discarding all the changes and only doing this 👇

abstract contract Test is DSTest, StdAssertions, StdCheats, StdUtils, TestBase {}

[mds1]

@ZeroEkkusu I pushed the required changes and verified the test now fails as expected. Feel free to review/merge