Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bug: PR 8543 means users can no longer console.log encoded URLs #8700

Closed
1 of 2 tasks
mds1 opened this issue Aug 20, 2024 · 0 comments · Fixed by #8702
Closed
1 of 2 tasks

bug: PR 8543 means users can no longer console.log encoded URLs #8700

mds1 opened this issue Aug 20, 2024 · 0 comments · Fixed by #8702
Labels
T-bug Type: bug T-needs-triage Type: this issue needs to be labelled

Comments

@mds1
Copy link
Collaborator

mds1 commented Aug 20, 2024 •
edited
Loading

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

None

Describe the bug

Using git bisect, I have identified #8543 as the PR which introduced the bug, which is detailed here: ethereum-optimism/superchain-ops#299 (comment)

The summary is that we often console.log Tenderly URLs, which use URL encoding sequences like %5D, %7D, and %7B. After that PR, the letter is swallowed and only e.g. %5 is printed. This results in a malformed URL being printed.

This has been a breaking change to our workflow as we can no longer rely on the printed URLs
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
T-bug Type: bug T-needs-triage Type: this issue needs to be labelled
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: console.log formatting foundry-rs/foundry
1 participant
@mds1