Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add "%ne" format support for forge console log #8543

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Jul 27, 2024

close #4841

@qiweiii qiweiii marked this pull request as ready for review July 28, 2024 04:36
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too familiar with the parsing impl, but afaict this looks correct

ptal @DaniPopes

crates/common/fmt/src/console.rs Outdated Show resolved Hide resolved
@mattsse mattsse requested a review from DaniPopes July 29, 2024 11:56
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @DaniPopes

@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 31, 2024
@mattsse mattsse enabled auto-merge (squash) August 6, 2024 11:41
@mattsse mattsse disabled auto-merge August 6, 2024 11:52
@mattsse mattsse enabled auto-merge (squash) August 6, 2024 11:52
@mattsse mattsse merged commit e9c8bf5 into foundry-rs:master Aug 6, 2024
20 checks passed
benwjhack pushed a commit to CompassLabs/foundry-test that referenced this pull request Sep 11, 2024
* wip

* fix

* fix sign

* fix

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "%ne" format support for forge console log
4 participants