Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add --anvil-header flag for customizing HTTP responses #10209

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Mar 29, 2025

Motivation

closes #8425.

Solution

  • Added new --anvil-header CLI flag that accepts multiple header values
  • Implemented header parsing and storage in ServerConfig
  • Modified HTTP response handler to include these headers in all responses
  • Used the same format as the existing --fork-header flag for consistency ("Name: Value")

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this isn't super invasive and isolated to the HTTP handler, I'm not sure we really need this

@crStiv
Copy link
Author

crStiv commented Mar 31, 2025

while this isn't super invasive and isolated to the HTTP handler, I'm not sure we really need this

oh... I've made changes and only after implementing them I've noticed what you've written

yeah I understand that it might not be what you need rn. but I'm just trying to do an issue, so what do you think I have to do rn?

is there any sense to continue working on this issue or nah?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feat: support --anvil-header for customizing anvil user-agent response
3 participants