fix(cli): Correct handling of compilation skipping in trace decoder #10254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This commit fixes an issue in the
handle_traces
function where it wasn't properly handling the case when project compilation is skipped due to no file changes.Previously, when the trace decoder encountered "No files changed, compilation skipped" message, the test
decode_traces_with_project_artifacts
failed due to mismatch between expected and actual output.Solution
The fix:
handle_traces
function incrates/cli/src/utils/cmd.rs
to correctly handle the case when compilation is skippedPR Checklist