feat: add some clippy lint #10479
Open
feat: add some clippy lint #10479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taikoonwang
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
previously approved these changes
May 9, 2025
zerosnacks
reviewed
May 9, 2025
zerosnacks
reviewed
May 9, 2025
taikoonwang
force-pushed
the
lint/cloned_instead_of_copied
branch
from
5919830 to
bd4445d
Compare
|
@grandizzy fixed some conflicts, plz review again |
taikoonwang
commented
May 13, 2025
| @@ -1535,7 +1534,6 @@ impl Backend { | |||
| let mut log_index = 0; | |||
| let mut gas_used = 0; | |||
| let mut transactions = Vec::with_capacity(calls.len()); | |||
| let mut receipts = Vec::new(); | |||
There was a problem hiding this comment.
warning: collection is never read
--> crates/anvil/src/eth/backend/mem/mod.rs:1537:17
|
1537 | let mut receipts = Vec::new();
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
torward: #10150
The above PR involved too many linting rules, so this time I want to split it into smaller PRs, similar to reth. Each PR will contain around 5 linting rules to make reviewing easier.
Solution
PR Checklist