Skip to content

chore: remove additional EOF leftovers #10506

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented May 13, 2025

Motivation

Follow-up of #10499

Noticed additional EOF related utilities and configurations we can clean up when I was rebasing

To do

Solution

Removes leftover EOF configurations and utilities

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks added L-ignore Log: ignore PR in changelog T-likely-breaking Type: requires changes that can be breaking and removed L-ignore Log: ignore PR in changelog labels May 13, 2025
@zerosnacks zerosnacks changed the title chore: remove EOF leftovers chore: remove additional EOF leftovers May 13, 2025
@zerosnacks zerosnacks marked this pull request as ready for review May 13, 2025 13:02
@zerosnacks zerosnacks moved this to Ready For Review in Foundry May 13, 2025
@zerosnacks zerosnacks self-assigned this May 13, 2025
@zerosnacks zerosnacks marked this pull request as draft May 14, 2025 11:47
@zerosnacks zerosnacks moved this from Ready For Review to In Progress in Foundry May 14, 2025
@zerosnacks
Copy link
Member Author

zerosnacks commented May 14, 2025

Marking this as draft again, #10454 highlighted some additional EOF handling we will be able to remove

@zerosnacks
Copy link
Member Author

Unblocked, will pick this up tomorrow

@zerosnacks zerosnacks marked this pull request as ready for review May 20, 2025 09:59
@zerosnacks zerosnacks moved this from In Progress to Ready For Review in Foundry May 20, 2025
@zerosnacks zerosnacks added this to the v1.3.0 milestone May 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-likely-breaking Type: requires changes that can be breaking
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

1 participant