feat(cast): Verbose signing output

[GregTheGreek]

Motivation

closes #10424

Adds some extra logging to the signing of a transaction.

Solution

I simply added two logs at the end of signing.

I wonder if this might be considered a breaking change? If some tools rely on the cli output to only return the signature, they would need to add extra parsing...

We could add a verbosity flag, open to ideas

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[mattsse]

this makes the output no longer usable with a regular pipe, so I think we can do this is --verbose is passed?

wdyt @zerosnacks

[GregTheGreek]

@mattsse been a while 👋

Could also add a new flag --full-output or something to not conflict with anything pre-existing

[mattsse]

gm ser, didn't notice the @ until now :D

ah, we even have this already here:

foundry/crates/cast/src/cmd/wallet/mod.rs

Lines 603 to 611 in 776897b

	if shell::verbosity() > 0 {
	sh_println!("Address: {}", wallet.address())?;
	sh_println!(
	"Private key: 0x{}",
	hex::encode(wallet.credential().to_bytes())
	)?;
	} else {
	sh_println!("0x{}", hex::encode(wallet.credential().to_bytes()))?;
	}

I believe this should respect the -v arg

[GregTheGreek]

ah, we even have this already here:

Not fully understanding your reply, that won't output the message & address though for sign?

[GregTheGreek]

@mattsse @zerosnacks Updated! Appreciate the feedback. Waiting for tests to re-run

[GregTheGreek]

TBH looking at the rest of the file, it might make sense to also do this for SignAuth, I can add that in if it makes sense to you all

Spoke to Matthias added

[mattsse]

lgtm!

ty

[zerosnacks]

Thanks!