feat(cast): display public_key on wallet creation with "new" and "new-mnemonic" sub-commands #10600
Conversation
mablr
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mablr
force-pushed
the
feature/cast-wallet-display-pubkey
branch
2 times, most recently
from
232b8f5 to
90ca4e6
Compare
…-mnemonic" subcommands The method used to obtain public_key with the wallet is taken from "public-key" subcommand. Update tests to match the new outputs: - match pubkey - update redactions for pubkey and to match various spacings - use raw data for assertion in "wallet_mnemonic_from_entropy" to avoid conflict with redactions
mablr
force-pushed
the
feature/cast-wallet-display-pubkey
branch
from
90ca4e6 to
ffeefa2
Compare
grandizzy
added
T-feature
There was a problem hiding this comment.
thank you, I think this makes sense (breaking change) @zerosnacks wdyt?
|
I think it is a bit verbose and for most use cases the level of detail seems unnecessary @mablr would you mind expanding on where you use the public keys? We already have the |
|
This feature was initially requested by @coffee-converter. @zerosnacks I agree with you and I shared the same concerns in comments on the related issue: #9748 (comment) & #9748 (comment). Some of the information is outdated, but the main idea is in line with your remark. After receiving feedback from @mattsse #9748 (comment), who assigned me to the issue, I finally implemented this feature. |
|
Hey @mablr, I see - thanks for the pointer! To my understanding @mattsse refers to In my opinion, I don't see a huge benefit to having this be logged, even at higher verbosity. I would be in favor of closing the ticket as |
|
I think you're right, limiting the pubkey display to a higher verbosity level (e.g. >1) is a good deal. |
Avoid breaking changes Some unit tests added for better coverage
grandizzy
removed
the
T-likely-breaking
There was a problem hiding this comment.
thank you, displaying on verbose lgtm! pending @zerosnacks review before merging
| &SecretKey::from_slice(&wallet.credential().to_bytes()) | ||
| .map_err(|e| eyre::eyre!("Invalid private key: {}", e))? | ||
| .public_key() | ||
| .to_encoded_point(false) | ||
| .as_bytes()[1..], |
There was a problem hiding this comment.
makes sense
@mablr do you want to perhaps upstream this to alloy's LocalSigner type as a helper?
There was a problem hiding this comment.
Yes, I can do it next week.
There was a problem hiding this comment.
sweet, tagged you here alloy-rs/alloy#2555
|
@mattsse Should this PR be marked as "blocked" until alloy-rs/alloy#2572 will land in the next release? |
Motivation
Resolve #9748
Solution
The method used to obtain public_key with the wallet is taken from "public-key" sub-command.
Update tests to match the new outputs:
EDIT:
PR Checklist
Added Documentation-vflag)