chore: bump to rust edition 2024 #10802
Open
+104
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zerosnacks
commented
Jun 18, 2025
| @@ -82,7 +82,6 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: dtolnay/rust-toolchain@nightly | |||
| with: | |||
| toolchain: nightly-2024-02-03 | |||
There was a problem hiding this comment.
Found out we were pinning to this specific nightly, this seems unintended / resolved
zerosnacks
commented
Jun 18, 2025
| @@ -46,7 +46,7 @@ pub struct HexIdProvider { | |||
|
|
|||
| impl HexIdProvider { | |||
| /// Generates a random hex encoded Id | |||
| pub fn gen(&self) -> String { | |||
There was a problem hiding this comment.
gen is now a reserved keyword, found generate better than r#gen
zerosnacks
commented
Jun 18, 2025
| @@ -20,7 +20,7 @@ impl Cheatcode for setEnvCall { | |||
| } else if value.contains('\0') { | |||
| Err(fmt_err!("environment variable value can't contain NUL character `\\0`")) | |||
| } else { | |||
| env::set_var(key, value); | |||
| unsafe { env::set_var(key, value); } | |||
There was a problem hiding this comment.
unsafe is now required for things that touch the environment
zerosnacks
commented
Jun 18, 2025
Comment on lines
+77
to
+78
| fuzz_state.clone(), | ||
| fuzz_fixtures.clone(), |
There was a problem hiding this comment.
Due to lifetime / ownership issues clone is not required here - not ideal!
zerosnacks
commented
Jun 18, 2025
| let settings = cache.profiles.get(&profile).expect("must be present"); | ||
|
|
||
| settings | ||
| cache.profiles.get(&profile).expect("must be present") |
There was a problem hiding this comment.
clippy lint rule now enforces returning the result of a let binding from a block preferring direct returns where possible
zerosnacks
commented
Jun 18, 2025
| @@ -514,7 +514,7 @@ impl<'a> InvariantExecutor<'a> { | |||
| invariant_contract: &InvariantContract<'_>, | |||
| fuzz_fixtures: &FuzzFixtures, | |||
| deployed_libs: &[Address], | |||
| ) -> Result<(InvariantTest, impl Strategy<Value = BasicTxDetails>)> { | |||
| ) -> Result<(InvariantTest, impl Strategy<Value = BasicTxDetails> + use<>)> { | |||
There was a problem hiding this comment.
+ use<> stems from https://rust-lang.github.io/rfcs/3617-precise-capturing.html, now required
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #10734
Solution
Initial commit was done as a trial run with Claude, worked quite well!
Some of the added
.clone()is concerning, will look for alternative solution to deal with ownership. We are mostly dealing withArc's and the other fields are likely light to clone.Expecting this PR to fail its lint check, doing that in a follow-up here: #10803 as the diff is very large in terms of number of files touched
PR Checklist