fix(verify): only include optimize infos when single file #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
T-feature
|
unfortunately no, tested this manually, with various modifications to the payload... not sure how to patch a hardhat project to log the etherscan request upon verify the etherscan API responses are also not very helpful -.- |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref gakonst/ethers-rs#1212
optimizationandrunsare only applicable in single file mode and not for std json compiler input, because that info is already included in the compiler input object.Ref https://docs.etherscan.io/api-endpoints/contracts#source-code-submission-gist
Solution