feat(forge): add gas snapshotting #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Dec 10, 2021
| help = "Compare against a snapshot and display changes from the snapshot. Takes an optional snapshot file, [default: .gas-snapshot]", | ||
| long | ||
| )] | ||
| diff: Option<Option<PathBuf>>, |
There was a problem hiding this comment.
yeah so this allows us to pass --diff as flag, in which case we take the .gas-snapshot file for comparison or
--diff to compare against a specific snapshot file
cli/src/cmd/snapshot.rs
Outdated
|
|
||
| fn run(self) -> eyre::Result<()> { | ||
| dbg!(self); | ||
| todo!() |
There was a problem hiding this comment.
What is the expected behavior for this?
There was a problem hiding this comment.
intended for check-snapshot as mentioned here dapphub/dapptools#761
Adding a dapp check-snapshot command that runs dapp snapshot (but outputs to a temp file instead of .dappshots) and compares it with .dappshots. If they don't match the command exits with an error.
| help = "Compare against a snapshot and display changes from the snapshot. Takes an optional snapshot file, [default: .gas-snapshot]", | ||
| long | ||
| )] | ||
| diff: Option<Option<PathBuf>>, |
mattsse
force-pushed
the
matt/gas-snapshot
branch
from
97e120d to
efd9a77
Compare
mattsse
force-pushed
the
matt/gas-snapshot
branch
from
efd9a77 to
b48cd3c
Compare
gakonst
approved these changes
Dec 11, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
forge.rsto their dedicated sub modulessnapshotcommand, that essentially "inherits" fromtestsnapshot --diff <snapshot>to print the diff from the current snapshot and an existing snapshot filesnapshot --check <snapshot>to check the current snapshot and an existing snapshot file, similar tocargo fmt --checkSupports all
forge testargumentsRef #137